Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circuit ordering in InterleavedRB (backport #1191) #1194

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 2, 2023

This is an automatic backport of pull request #1191 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

### Summary
Changes the ordering of circuits generated by `InterleavedRB` back to
RIRIRI (R: Reference, I: Interleaved) order. It was accidentally changed
into RRRIII order in #898. Before that, it had been RIRIRI order.

### Details and comments
This change may slightly alter the impact of noise on IRB results.
RIRIRI ordering is preferable in the sense that it minimizes the impact
of drift or noise fluctuations. Note that `InterleavedRBAnalysis` is not
changed that means it works correctly regardless of the circuit ordering
because it processes data relying on "interleaved" flag in circuit
metadata.

This commit also adds a new experiment option `circuit_order` to
`InterleavedRB`. It enables to change the order of the reference and the
interleaved circuits and hence slightly alter the impact of noise on
interleaved RB results. The default value is set to `"RIRIRI"`.

(cherry picked from commit c6753f3)
@coruscating coruscating added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jun 5, 2023
@coruscating coruscating merged commit 920c4a5 into stable/0.5 Jun 29, 2023
@coruscating coruscating deleted the mergify/bp/stable/0.5/pr-1191 branch June 29, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants