Update FakeBackend to use BackendV2 #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| default_config.update(**config) | ||
| super().__init__(QasmBackendConfiguration(**default_config)) | ||
| target = None |
There was a problem hiding this comment.
Overriding abstract property method in this way seems hacky. I prefer to define a protected member and return it through property method as long as the base class provides such mechanism.
There was a problem hiding this comment.
I agree that is more proper. I copied this from MinimalBackend, so I updated both classes in this PR now. I think for MinimalBackend I had been thinking I wanted to do backend.target = Target() in tests to test out different Target configurations but that wasn't a good reason to deviate from it being a property.
nkanazawa1989
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change set updates the
FakeBackendused by some tests to derive fromBackendV2rather thanBackendV1Details and comments
When combined with #900 which updates some calibration tests and #1040 which updates
T2HahnBackend, this change results in almost all the tests in the test suite usingBackendV2. The remaining tests using aBackendthat is notBackendV2use theAerSimulatorwhich will be updated toBackendV2in the future (tracked in Qiskit/qiskit-aer#1681). The check for backend type was performed by merging the calibration andT2HahnBackendbranches into this branch and running the tests withBaseExperiment.run(),BaseExperiment._set_backend(), andCalibrations.from_backend()updated to error if thebackendargument was notBackendV2orAerSimulatorand confirming that all the tests passed.