Fix panic in dump reordering after swap #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where state dump could crash if run after a swap of qubit ids. Specifically, a qubit id swap followed by a release of one of the qubits can put the id map into a state where not every desired id for the swap is occupied by an existing qubit. As a result, updating the map for the swapped key should be a best effort and not a panic if the key is not present. Also adds a unit test to cover this specific case.
idavis
approved these changes
May 12, 2023
swernli
added a commit
to microsoft/qsharp
that referenced
this pull request
May 12, 2023
This change includes two bugfixes: - Evaluator now checks for qubit argument uniques on intrinsic gate invocation to avoid triggering a panic in the simulator (treated instead as a runtime error). - Updates to a simulator package with the bug fix for dumping state after a swap of two qubits where one has been released (see qir-alliance/qir-runner#67)
swernli
added a commit
to microsoft/qsharp
that referenced
this pull request
May 12, 2023
This change includes two bugfixes: - Evaluator now checks for qubit argument uniques on intrinsic gate invocation to avoid triggering a panic in the simulator (treated instead as a runtime error). - Updates to a simulator package with the bug fix for dumping state after a swap of two qubits where one has been released (see qir-alliance/qir-runner#67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where state dump could crash if run after a swap of qubit ids. Specifically, a qubit id swap followed by a release of one of the qubits can put the id map into a state where not every desired id for the swap is occupied by an existing qubit. As a result, updating the map for the swapped key should be a best effort and not a panic if the key is not present. Also adds a unit test to cover this specific case.