Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize artifacts and targets #181

Merged
merged 13 commits into from
May 31, 2024
Merged

Finalize artifacts and targets #181

merged 13 commits into from
May 31, 2024

Conversation

idavis
Copy link
Collaborator

@idavis idavis commented May 30, 2024 •
edited
Loading

  • New sdist for platforms we don't release
  • Creating qir stdlib releases
  • Simplifying CI now that releases are done through ADO
  • Removing aarch mac and universal builds as they don't fully work xplat

@idavis idavis self-assigned this May 30, 2024
@idavis idavis requested review from billti and swernli as code owners May 30, 2024 18:54
@idavis idavis force-pushed the iadavis/pipeline-cleanup branch from 6cd5ecf to 324ce41 Compare May 30, 2024 18:56
swernli
swernli reviewed May 31, 2024
View reviewed changes
notice.ps1 Show resolved Hide resolved
swernli
swernli approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on an empty file, but otherwise things look good!

@idavis idavis force-pushed the iadavis/pipeline-cleanup branch from 4494a2d to a074b2c Compare May 31, 2024 14:55
swernli
swernli approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on removing the unused feature!

@idavis idavis merged commit 1c9f30c into main May 31, 2024
14 checks passed
@idavis idavis deleted the iadavis/pipeline-cleanup branch May 31, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

Assignees

@idavis idavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idavis @swernli