Fix phase gate matrix, test utility #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test utility for comparing simulator functions against matrix applications was not using enough qubits to fully verify the resulting state, and fixing this revealed a bug in the way `mcphase` was used to implement a multicontrolled Ri rotation (the phase was not applied globally). This change updates the tests and fixes `mcphase` to apply to all states instead of just states with a 1 in the computational basis.
swernli
changed the title
idavis
reviewed
Apr 3, 2024
idavis
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test utility for comparing simulator functions against matrix applications was not using enough qubits to fully verify the resulting state, and fixing this revealed a bug in the matrix used for testing the
mcphaseoperation. The matrix is also updated such that the enhanced test now passes.