fix: remove linterName from agent

config/config.go

@@ -200,6 +200,10 @@ func applyCustomConfig(legacy, custom Linter) Linter {
 		legacy.DockerAsRunner.CopyLinterFromOrigin = custom.DockerAsRunner.CopyLinterFromOrigin
 	}
 
+	if custom.Name != "" {
+		legacy.Name = custom.Name
+	}
+
 	return legacy
 }
 

internal/linters/github.go

@@ -133,7 +133,7 @@ func CreateGithubChecks(ctx context.Context, a Agent, lintErrs map[string][]Lint
 		owner      = a.PullRequestEvent.Repo.GetOwner().GetLogin()
 		repo       = a.PullRequestEvent.Repo.GetName()
 		startTime  = a.PullRequestEvent.GetPullRequest().GetUpdatedAt()
-		linterName = a.LinterName
+		linterName = a.LinterConfig.Name
 	)
 
 	annotations := toGithubCheckRunAnnotations(lintErrs)

internal/linters/linters.go

@@ -119,8 +119,6 @@ type Agent struct {
 	PullRequestEvent github.PullRequestEvent
 	// PullRequestChangedFiles is the changed files of a pull request.
 	PullRequestChangedFiles []*github.CommitFile
-	// LinterName is the linter name.
-	LinterName string
 	// RepoDir is the repo directory.
 	RepoDir string
 
@@ -147,7 +145,7 @@ If you have any questions about this comment, feel free to raise an issue here:
 type LinterParser func(*xlog.Logger, []byte) (map[string][]LinterOutput, []string)
 
 func GeneralHandler(log *xlog.Logger, a Agent, execRun func(a Agent) ([]byte, error), linterParser func(*xlog.Logger, []byte) (map[string][]LinterOutput, []string)) error {
-	linterName := a.LinterName
+	linterName := a.LinterConfig.Name
 	output, err := execRun(a)
 	if err != nil {
 		// NOTE(CarlJi): the error is *ExitError, it seems to have little information and needs to be handled in a better way.
@@ -212,7 +210,7 @@ func Report(log *xlog.Logger, a Agent, lintResults map[string][]LinterOutput) er
 		org        = a.PullRequestEvent.Repo.GetOwner().GetLogin()
 		repo       = a.PullRequestEvent.Repo.GetName()
 		orgRepo    = a.PullRequestEvent.Repo.GetFullName()
-		linterName = a.LinterName
+		linterName = a.LinterConfig.Name
 	)
 
 	log.Infof("[%s] found total %d files with %d lint errors on repo %v", linterName, len(lintResults), countLinterErrors(lintResults), orgRepo)

internal/linters/linters_test.go

@@ -187,7 +187,6 @@ func TestExecRun(t *testing.T) {
 		{
 			id: "case1 - without ARTIFACT",
 			input: Agent{
-				LinterName: "ut",
 				LinterConfig: config.Linter{
 					Enable:       &tp,
 					Command:      []string{"/bin/bash", "-c", "--"},
@@ -201,7 +200,6 @@ func TestExecRun(t *testing.T) {
 		{
 			id: "case2 - with ARTIFACT",
 			input: Agent{
-				LinterName: "ut",
 				LinterConfig: config.Linter{
 					Enable:       &tp,
 					Command:      []string{"/bin/bash", "-c", "--"},
@@ -215,7 +213,6 @@ func TestExecRun(t *testing.T) {
 		{
 			id: "case2 - with multi files under ARTIFACT",
 			input: Agent{
-				LinterName: "ut",
 				LinterConfig: config.Linter{
 					Enable:       &tp,
 					Command:      []string{"/bin/bash", "-c", "--"},

server.go

@@ -270,7 +270,6 @@ func (s *Server) handle(ctx context.Context, event *github.PullRequestEvent) err
 			GitClient:               s.gitClientFactory,
 			PullRequestEvent:        *event,
 			PullRequestChangedFiles: pullRequestAffectedFiles,
-			LinterName:              name,
 			RepoDir:                 r.Directory(),
 			Context:                 ctx,
 			ID:                      uuid.New().String(),
@@ -288,7 +287,7 @@ func (s *Server) handle(ctx context.Context, event *github.PullRequestEvent) err
 		agent.Runner = r
 		agent.Storage = s.storage
 		agent.GenLogKey = func() string {
-			return fmt.Sprintf("%s/%s/%s", agent.LinterName, agent.PullRequestEvent.Repo.GetFullName(), agent.ID)
+			return fmt.Sprintf("%s/%s/%s", agent.LinterConfig.Name, agent.PullRequestEvent.Repo.GetFullName(), agent.ID)
 		}
 		agent.GenLogViewUrl = func() string {
 			// if serverAddr is not provided, return empty string