Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Initialize, timeTicker #279

Merged
merged 3 commits into from
Aug 13, 2020
Merged

add Initialize, timeTicker #279

merged 3 commits into from
Aug 13, 2020

Conversation

sxci
Copy link
Collaborator

@sxci sxci commented Aug 13, 2020

变更背景描述

添加参数控制 fusion 刷新、预取频率,每次提交条数;---- --qps 1 -s 50
预先判断是否 debug 模式,打印不同信息; --- OnInitialize

jira issue链接

主要变更点

  • [*]fix bug
  • []new feature
  • []不兼容变更

Checklist

  • [*] 已自测
  • [] 已更新Readme

qps 限制参数放到每个具体的指令里,还是放到 cobra RootCmd.PersistentFlags() 里?

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #279 into master will increase coverage by 0.08%.
The diff coverage is 23.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #279      +/-   ##
=========================================
+ Coverage    6.67%   6.76%   +0.08%     
=========================================
  Files          40      40              
  Lines        4851    4876      +25     
=========================================
+ Hits          324     330       +6     
- Misses       4522    4540      +18     
- Partials        5       6       +1     
Impacted Files Coverage Δ
cmd/cdn.go 9.09% <20.83%> (+3.53%) ⬆️
cmd/root.go 16.39% <33.33%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab5b07...8c80b9c. Read the comment docs.

@bachue
Copy link
Contributor

bachue commented Aug 13, 2020

/lgtm

@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bachue, sxci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiniu-bot qiniu-bot merged commit 2ab8bc4 into qiniu:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants