Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add config transpileOnlyWhenDev for tsx? transform #46

Merged
merged 4 commits into from
Dec 26, 2017
Merged

add config transpileOnlyWhenDev for tsx? transform #46

merged 4 commits into from
Dec 26, 2017

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Dec 26, 2017 •
edited
Loading

@nighca
Copy link
Collaborator Author

nighca commented Dec 26, 2017

@doxiaodong @yanhao1991 求 review

alexmaze
alexmaze approved these changes Dec 26, 2017
View reviewed changes
Copy link
Contributor

@alexmaze alexmaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@nighca
Copy link
Collaborator Author

nighca commented Dec 26, 2017 •
edited
Loading

@yanhao1991 我在本地试我们这边的项目，配置这个配置项 false 的时候发现 serve 时有一些奇怪的类型错误（比如找不到 node 的一些全局值，process 这些，其实项目里是有 @types/node 包的），它们在直接本地跑 tsc（我们本地 typescript 是 2.3.4）的情况下不会出现，我还不确定是 ts 2.4 还是 builder 本身的原因导致的；不过你那可能也会遇到类似的问题，我暂时没时间查，你要是也遇到了有时间帮查一下原因是最好了

这个我先合了，如果是 builder 的问题的话后边再修

alexmaze
alexmaze approved these changes Dec 26, 2017
View reviewed changes
Copy link
Contributor

@alexmaze alexmaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nighca nighca merged commit 73828c5 into qiniu:master Dec 26, 2017
@wangkechun wangkechun mentioned this pull request Jan 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doxiaodong doxiaodong doxiaodong approved these changes

@alexmaze alexmaze alexmaze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

支持通过参数启用 lint 检查
3 participants
@nighca @alexmaze @doxiaodong