forked from WICG/turtledove
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
spec cumulative-buyer-time and percent-igs-cumulative-timeout (WICG#1353
) * Reserved.once specification. * Some metrics stuff, but it's a bit off for re-run, so need to think some more. Actually implement the get. * Fix handwaveyness of fetch metrics. * Fix the re-run thing, and a bit of prep for later. * Fix formatting. * Fix bug + misc found in feedback. * Typo fix. * Wire timeout from most script helpers. * Start on actual computation. * k-anon only. The impl gets it wrong. * generateBid computation. * report* * And add the base value itself. * Fix participating IG count computation. * Back to always. * Fix the reportAdditionalWin case. * Improve report-win enum at suggestion. * Fix edit mishap * Spec various P.Agg. storage usage base values. * Woops, forgot some descriptions. * Start on cumul timeout refactors. Need to think a few more details. * Proper last execution stuff, percent-igs-cumulative-timeout * cumulative-buyer-time + proper percent-... in reportWin. * Apply feedback * Apply feedback * + PA contributions type * More feedback * More phrasing tweaks. * More add -> increment * Some feedback * Fix the error case Qingxin pointed out. * Explain 110% * Fix the parse error case Qingxin pointed out, lack of timeout on top-level run is orthogonal. * Fix the lack of timeout on ScriptExecution. * More feedback * Switchify * FIx weird wrap. * Fix time of check on re-run. * Apply first batch of feedback comments. * Link our struct fields to base values they are used for. * More feedback --------- Co-authored-by: Maks Orlovich <[email protected]>
- Loading branch information
Showing
1 changed file
with
131 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters