-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add get insert id after insert #132
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 42.10% 42.23% +0.12%
==========================================
Files 22 22
Lines 2978 2986 +8
==========================================
+ Hits 1254 1261 +7
- Misses 1724 1725 +1 ☔ View full report in Codecov by Sentry. |
include/mysql.hpp
Outdated
std::optional<uint64_t> insert_id = {0}; | ||
insert_or_update_impl(t, generate_insert_sql<T>(true), OptType::insert, | ||
std::move(insert_id)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改成
insert_or_update_impl(t, generate_insert_sql<T>(true), OptType::insert, 0);
数字可以直接赋值给optional的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.