fix parse insert sql #126
Merged
fix parse insert sql #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 39.88% 39.88%
=======================================
Files 22 22
Lines 2856 2856
=======================================
Hits 1139 1139
Misses 1717 1717 ☔ View full report in Codecov by Sentry. |
qicosmos
reviewed
Nov 14, 2023
Comment on lines
+215
to
+222
| if (fields.back() != ')') { | ||
| fields.pop_back(); | ||
| fields.back() = ')'; | ||
| } | ||
| if (values.back() != ')') { | ||
| values.pop_back(); | ||
| values.back() = ')'; | ||
| } |
There was a problem hiding this comment.
之前是什么bug呢，什么现象？在pr说明注明一下。现在单测是不是覆盖了这些代码？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.