Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute asymmetry in resonator flux fit #978

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Sep 6, 2024

Now the resonator flux dependence fit will compute also the asymmetry.
It will also update both the matrix element and the sweetspot.
Here is a report: http://login.qrccluster.com:9000/IJapdzbeQUmTfiwfTeKhwQ==/

  • Fix resonator crosstalk

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Now the resonator flux dependence fit will compute also the asymmetry.
It will also update both the matrix element and the sweetspot.
@andrea-pasquale andrea-pasquale marked this pull request as draft September 6, 2024 08:01
@andrea-pasquale andrea-pasquale marked this pull request as ready for review September 24, 2024 07:55
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (22f62d5) to head (abcc1d0).
Report is 48 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   97.50%   97.49%   -0.01%     
==========================================
  Files         123      123              
  Lines        9722     9734      +12     
==========================================
+ Hits         9479     9490      +11     
- Misses        243      244       +1     
Flag Coverage Δ
unittests 97.49% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...l/protocols/flux_dependence/resonator_crosstalk.py 96.89% <100.00%> (-0.50%) ⬇️
...ocols/flux_dependence/resonator_flux_dependence.py 98.31% <100.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

@Edoardo-Pedicillo Edoardo-Pedicillo added this to the Qibocal 0.1.1 milestone Oct 3, 2024
@andrea-pasquale andrea-pasquale added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 35c53bd Oct 22, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the improve_resonator_flux branch October 22, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants