Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dispersive shift with qutrits #574

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

andrea-pasquale
Copy link
Contributor

This PR adds a dispersive shift including state 2.

image

(This one is not fully characterized but it is just to show that it works)

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #574 (c6d5c4e) into main (a731ce0) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   96.00%   96.13%   +0.13%     
==========================================
  Files          94       95       +1     
  Lines        6353     6466     +113     
==========================================
+ Hits         6099     6216     +117     
+ Misses        254      250       -4     
Flag Coverage Δ
unittests 96.13% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/protocols/characterization/__init__.py 100.00% <100.00%> (ø)
...tocols/characterization/dispersive_shift_qutrit.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@GabrielePalazzo GabrielePalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems correct to me.

@GabrielePalazzo
Copy link
Contributor

I just tested it on iqm5q and it doesn't work:

Traceback (most recent call last):
  File "/nfs/users/gabriele.palazzo/qibocal/.venv/bin/qq", line 8, in <module>
    sys.exit(command())
  File "/nfs/users/gabriele.palazzo/qibocal/.venv/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/nfs/users/gabriele.palazzo/qibocal/.venv/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/nfs/users/gabriele.palazzo/qibocal/.venv/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/nfs/users/gabriele.palazzo/qibocal/.venv/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/nfs/users/gabriele.palazzo/qibocal/.venv/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/nfs/users/gabriele.palazzo/qibocal/src/qibocal/cli/_base.py", line 53, in auto
    autocalibrate(card, folder, force, update)
  File "/nfs/users/gabriele.palazzo/qibocal/src/qibocal/cli/autocalibration.py", line 61, in autocalibrate
    for task_uid in executor.run(mode=ExecutionMode.autocalibration):
  File "/nfs/users/gabriele.palazzo/qibocal/src/qibocal/auto/execute.py", line 136, in run
    completed = task.run(
  File "/nfs/users/gabriele.palazzo/qibocal/src/qibocal/auto/task.py", line 146, in run
    completed.data, completed.data_time = operation.acquisition(
  File "/nfs/users/gabriele.palazzo/qibocal/src/qibocal/auto/operation.py", line 41, in wrapper
    out = func(*args, **kwds)
  File "/nfs/users/gabriele.palazzo/qibocal/src/qibocal/protocols/characterization/dispersive_shift_qutrit.py", line 98, in _acquisition
    rx_12_pulse = platform.create_RX12_pulse(qubit, start=rx_pulse.finish)
  File "/nfs/users/gabriele.palazzo/qibolab/src/qibolab/platform.py", line 262, in create_RX12_pulse
    return self.qubits[qubit].native_gates.RX12.pulse(start, relative_phase)
AttributeError: 'NoneType' object has no attribute 'pulse'

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 158e7e6 Nov 2, 2023
21 checks passed
@andrea-pasquale andrea-pasquale deleted the dispersive_qutrit branch November 2, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants