Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in chsh_circuits, measure qubits simultaneously #1040

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

hay-k
Copy link
Contributor

@hay-k hay-k commented Nov 11, 2024

In principle, qiboteam/qibolab#1096 should address the issue of chsh_circuits producing different results compared to chsh_pulses*, however in the definitions of experiments it is still good to explicitly have qubits measured at once/in one circuit moment.

* The discrepancy is clearly visible in this two reports: chsh_pulses, chsh_circuits

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (31efd4d) to head (c643fc0).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
+ Coverage   97.34%   97.36%   +0.02%     
==========================================
  Files         120      120              
  Lines        9750     9749       -1     
==========================================
+ Hits         9491     9492       +1     
+ Misses        259      257       -2     
Flag Coverage Δ
unittests 97.36% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/protocols/readout_mitigation_matrix.py 100.00% <100.00%> (ø)
...l/protocols/two_qubit_interaction/chsh/circuits.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@hay-k hay-k added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit c8cd2a9 Nov 13, 2024
21 checks passed
@hay-k hay-k deleted the measure_together branch November 13, 2024 06:17
@Edoardo-Pedicillo Edoardo-Pedicillo mentioned this pull request Nov 13, 2024
8 tasks
@Edoardo-Pedicillo Edoardo-Pedicillo added this to the Qibocal 0.1.1 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants