Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing wheels #290

Merged
merged 1 commit into from
Dec 3, 2020
Merged

testing wheels #290

merged 1 commit into from
Dec 3, 2020

Conversation

scarrazza
Copy link
Member

@scarrazza scarrazza commented Dec 2, 2020

This PR introduces a check for generated whl files. This also fixes the libomp dependency, now the user does not need to install libomp with homebrew before using Qibo.

There is an issue that has to be solved for linux pypa/manylinux#836

@scarrazza scarrazza requested a review from stavros11 December 2, 2020 19:17
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #290 (0b428c9) into master (8119c5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #290   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        54           
  Lines        10562     10562           
=========================================
  Hits         10562     10562           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8119c5d...0b428c9. Read the comment docs.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

pip install -r requirements.txt
python setup.py bdist_wheel
pip install delocate
cd dist
delocate-wheel -v `ls`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not relevant for the GitHub actions, but when I try to run this in my local machine it fails with the following message:

FileNotFoundError: [Errno 2] No such file or directory: 'otool'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a macos specific tool, on linux we have ldd which does the same job.

@scarrazza scarrazza merged commit 306ce0d into master Dec 3, 2020
@scarrazza scarrazza deleted the testwheels branch February 6, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants