Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming backend methods related to vector and matrix norms #1520

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

renatomello
Copy link
Contributor

Closes #1518

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added this to the Qibo 0.2.14 milestone Nov 12, 2024
@renatomello renatomello self-assigned this Nov 12, 2024
@renatomello
Copy link
Contributor Author

@MatteoRobbiati @BrunoLiegiBastonLiegi do you know what is this error in the tests regarding importing tensorflow from qiboml?

https://github.com/qiboteam/qibo/actions/runs/11794483631/job/32852177151?pr=1520

@BrunoLiegiBastonLiegi
Copy link
Contributor

Mmmh weird, but the tests under tensorflow are still running?

@MatteoRobbiati
Copy link
Contributor

I think what is strange is that it didn't fail before: tensorflow is no more a dependency, thus shouldn't this line always set tensorflow to False?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename backend methods related to norms
3 participants