Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependency between MeasurementResult and M gate #1465

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

BrunoLiegiBastonLiegi
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi commented Sep 25, 2024

This should close #1433

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (68bdb98) to head (21f0d7e).
Report is 27 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1465   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          81       81           
  Lines       11740    11740           
=======================================
  Hits        11733    11733           
  Misses          7        7           
Flag Coverage Δ
unittests 99.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi marked this pull request as ready for review September 25, 2024 17:40
@MatteoRobbiati MatteoRobbiati added this to the Qibo 0.2.13 milestone Oct 2, 2024
Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BrunoLiegiBastonLiegi, good catch.

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@renatomello renatomello added this pull request to the merge queue Oct 7, 2024
Merged via the queue into master with commit 2bb08e0 Oct 7, 2024
28 checks passed
@renatomello renatomello deleted the measurement_result_from_qubits branch October 7, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cyclic dependence of gate M and MeasurementResult
4 participants