Save gates to JSON #1015
Save gates to JSON #1015
Conversation
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
If you have anything that could be simple to add I can try to implement it as well. |
That's the main problem: it might not be too simple. |
| from typing import List, Sequence, Tuple | ||
|
|
||
| import sympy | ||
|
|
||
| from qibo.backends import GlobalBackend | ||
| from qibo.config import raise_error | ||
|
|
||
| REQUIRED_FIELDS = ["name", "init_kwargs", "_target_qubits", "_control_qubits"] | ||
| REQUIRED_FIELDS_INIT_KWARGS = ["theta", "phi", "lam"] |
There was a problem hiding this comment.
You could include the trainable here, right? Might be relevant for some applications, but I am not sure if those would use the serialization anyway.
There was a problem hiding this comment.
Yeah, I don't know either, for what I needed it wasn't necessary. This can extended as the application that requires it appears. I would try to save the least for now.
There was a problem hiding this comment.
Agreed, let's stick to something simple.
I want to rework the gates anyhow, and (if possible) write a simpler and more robust serialization. Maybe we will need to improve this in any case, but maybe not.
It does save the unitaries. In fact, most of the gates the RB saves are unitaries. |
Naive patch to save gates in RB implemented changes in qiboteam/qibocal#412.
Checklist: