3d/elevation profile: Use absolute clamping for 3d data #60186
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Tests failed for Qt 6One or more tests failed using the build from commit a38e99c ambient_occlusion_1 (testAmbientOcclusion)ambient_occlusion_1Test failed at testAmbientOcclusion at tests/src/3d/testqgs3drendering.cpp:2024 Rendered image did not match tests/testdata/control_images/3d/expected_ambient_occlusion_1/expected_ambient_occlusion_1.png (found 100023 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Tests failed for Qt 5One or more tests failed using the build from commit a38e99c ambient_occlusion_1 (testAmbientOcclusion)ambient_occlusion_1Test failed at testAmbientOcclusion at tests/src/3d/testqgs3drendering.cpp:2024 Rendered image did not match tests/testdata/control_images/3d/expected_ambient_occlusion_1/expected_ambient_occlusion_1.png (found 100023 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
ptitjano
force-pushed
the
profile-absolute
branch
2 times, most recently
from
bf04f42 to
46d5638
Compare
When providing a project DTM/DEM, the default behavior for vector feature with a z-component is to offset the $z coordinates from the terrain elevation model in the elevation profile view. However, the geometry coordinates are supposed to be absolute. So it makes more sense, to only use the $z coordinate by default in that case. Related: qgis#59757
When providing a project DTM/DEM, the default behavior for vector feature with a z-component is to offset the $z coordinates from the terrain elevation model in the elevation profile view. However, the geometry coordinates are supposed to be absolute. So it makes more sense, to only use the $z coordinate by default in that case. The different unit tests are updated accordingly. Closes: qgis#59757
ptitjano
force-pushed
the
profile-absolute
branch
from
46d5638 to
7451b89
Compare
Description
This is a second attempt based on #59759 which was auto closed because of the lack of reaction
When providing a project DTM/DEM, the default behavior for vector feature with a z-component is to offset the $z coordinates from the terrain elevation model in the elevation profile view. However, the geometry coordinates are supposed to be absolute.
So it makes more sense, to only use the $z coordinate by default in that case.
See: #59757
cc @T4mmi