Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh layer remove datasetgroup #59382

Merged
merged 36 commits into from
Dec 11, 2024
Merged

Conversation

JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Nov 8, 2024

Description

Adds option to add Dataset Groups to Mesh Layer with the same name (but not from the same uri), the Dataset Group names are automatically renamed to "Original Name _Number", for clarity.

Adds option to remove Dataset Groups from Mesh Layer. Only additional Dataset Groups (not associated with mesh source file) can be removed.

Includes GUI interface:

add-remove-datasetgroup jpg

@JanCaha JanCaha changed the title Meshlayer remove datasetgroup Mesh layer remove datasetgroup Nov 8, 2024
@github-actions github-actions bot added this to the 3.42.0 milestone Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 62d87a7)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 62d87a7)

@DelazJ DelazJ added Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Nov 11, 2024
@qgis-bot
Copy link
Collaborator

@JanCaha
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@JanCaha

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's some nice functionality!

src/providers/mdal/qgsmdalprovider.cpp Outdated Show resolved Hide resolved
src/providers/mdal/qgsmdalprovider.cpp Outdated Show resolved Hide resolved
src/providers/mdal/qgsmdalprovider.cpp Outdated Show resolved Hide resolved
src/providers/mdal/qgsmdalprovider.h Show resolved Hide resolved
src/providers/mdal/qgsmdalprovider.cpp Outdated Show resolved Hide resolved
src/core/mesh/qgsmeshlayer.h Outdated Show resolved Hide resolved
src/core/mesh/qgsmeshdataprovider.h Outdated Show resolved Hide resolved
src/core/mesh/qgsmeshdatasetgroupstore.cpp Outdated Show resolved Hide resolved
src/core/mesh/qgsmeshdatasetgroupstore.h Show resolved Hide resolved
src/core/mesh/qgsmeshdataprovider.h Outdated Show resolved Hide resolved
Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor last const stuff (I also unresolved two previous const comments)

src/core/mesh/qgsmeshlayer.h Outdated Show resolved Hide resolved
src/core/mesh/qgsmeshdatasetgroupstore.cpp Outdated Show resolved Hide resolved
src/core/mesh/qgsmeshdatasetgroupstore.cpp Outdated Show resolved Hide resolved
src/providers/mdal/qgsmdalprovider.cpp Outdated Show resolved Hide resolved
@uclaros uclaros merged commit 254614b into qgis:master Dec 11, 2024
31 checks passed
@qgis-bot
Copy link
Collaborator

@JanCaha
A documentation ticket has been opened at qgis/QGIS-Documentation#9464
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog Items that are queued to appear in the visual changelog - remove after harvesting Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants