Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Restore MSYS2/MinGW-w64 and move it to Qt6 #59377

Closed
wants to merge 5 commits into from

Conversation

MehdiChinoune
Copy link
Contributor

Description

Re-enable MSYS2/MinGW-w64 job but with Qt6.

@github-actions github-actions bot added this to the 3.42.0 milestone Nov 8, 2024
@nyalldawson
Copy link
Collaborator

I'm -1 to introducing another ci build, UNLESS we can drop one of the existing ones or it's extremely high priority. There's just so many long running jobs here already. 🫤

- It's a cross building not native
- It's not ready for Qt6 as packages required are not available from  Fedora.
@MehdiChinoune
Copy link
Contributor Author

I'm -1 to introducing another ci build, UNLESS we can drop one of the existing ones or it's extremely high priority. There's just so many long running jobs here already. 🫤

I dropped MINGW64 (Fedora) job.

@nyalldawson
Copy link
Collaborator

@MehdiChinoune but why is this job more useful then the mingw one? As far as I see it:

  • the mingw one provides a nicely packaged build ready for users to test
  • the mingw build uses qt5, which is still the official supported qt version for qgis
  • this msys build is now qt6 and duplicates the other qt 6 one, but that one also provides the useful SDK

So of the 3 windows builds, the msys2 one seems least useful to me...

@nicogodet
Copy link
Member

Qt5 builds is still relevant as migration to Qt6 is not completely done yet (I reported a crash on qt6 which doesn't happen in qt5).
Previous job built an artifact to easily test a PR.
-1

@MehdiChinoune
Copy link
Contributor Author

@MehdiChinoune but why is this job more useful then the mingw one? As far as I see it:

  • the mingw one provides a nicely packaged build ready for users to test
  • the mingw build uses qt5, which is still the official supported qt version for qgis

So, let's keep it

  • this msys build is now qt6 and duplicates the other qt 6 one, but that one also provides the useful SDK

So of the 3 windows builds, the msys2 one seems least useful to me...

So you don't want to test MinGW-w64 + Qt6?

You know that MinGW is different than MSVC!

@MehdiChinoune MehdiChinoune deleted the mingw-ci-qt6 branch November 8, 2024 06:46
Copy link

github-actions bot commented Nov 8, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit d546e1f)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit d546e1f)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants