[FEATURE] [Identify tool] Present referencing relations (in addition … #57863

rouault · 2024-06-24T16:52:04Z

…to referenced ones), and support them on arbitrary nesting level

Previously only referenced relations where presented when exploring a feature, now referenced ones are presented as well. Do that only when the user explicit unfolds a node, to avoid potential 'explosion' of the number of features in the tree in case of a huge database where all features would be connected through relations. If through relations a feature already present in an ancestor node is detected, it is omitted from the related features.

Add setting parameters to disable showing relations

Add a contextual menu item "Identify Feature" to be able to "re-center" the result of the identification tree on a nested feature, to limit the nesting depth.

==>

…to referenced ones), and support them on arbitrary nesting level Fixes qgis#48776 Previously only referenced relations where presented when exploring a feature, now referenced ones are presented as well. Do that only when the user explicit unfolds a node, to avoid potential 'explosion' of the number of features in the tree in case of a huge database where all features would be connected through relations. If through relations a feature already present in an ancestor node is detected, it is omitted from the related features. Add setting parameters to disable showing referenced and referencing relations. Add a contextual menu item "Explore Feature" to be able to "re-center" the result of the identification tree on a nested feature, to limit the nesting depth.

github-actions · 2024-06-24T17:16:29Z

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 76a0c7f)

nyalldawson · 2024-06-24T19:56:01Z

src/app/qgsidentifyresultsdialog.cpp

+          QFont italicFont;
+          italicFont.setItalic( true );
+          relationItem->setFont( 0, italicFont );
+          relationItem->setData( 0, Qt::UserRole, QVariant::fromValue( qobject_cast<QObject *>( relation.referencedLayer() ) ) );


This looks dangerous -- do we do this elsewhere? I think it'd be safer to use the layer id here instead . Otherwise there could be a crash if the child layer is removed before the relation is expanded

This looks dangerous -- do we do this elsewhere?

yes, for example

QGIS/src/app/qgsidentifyresultsdialog.cpp

Line 568 in 81c28c4

layItem->setData( 0, Qt::UserRole, QVariant::fromValue( qobject_cast<QObject *>( vlayer ) ) );

. But they also connected to QgsIdentifyResultsDialog::layerDestroyed() to remove nodes from the tree, which was missing for the relations. I've added this connection and enhanced layerDestroyed() to remove items that are linked to a layer, but not necessarily as top items.

nyalldawson · 2024-06-24T19:57:16Z

src/ui/qgsidentifyresultsbase.ui

+    <bool>true</bool>
+   </property>
+   <property name="text">
+    <string>Show referenced relations</string>


Suggested change

<string>Show referenced relations</string>

<string>Show Referenced Relations</string>

done, and merged as a single setting as suggested

src/ui/qgsidentifyresultsbase.ui

nyalldawson · 2024-06-24T20:01:50Z

tests/src/app/testqgsidentifyresultsdialog.cpp

@@ -0,0 +1,270 @@
+/***************************************************************************
+     testqgsidentifyresultsdialog.cpp


There's other tests for the dialog in the identify map tool tests. Maybe we should put these new ones in there, and then rename to just testqgsidentify.cpp?

nyalldawson · 2024-06-24T20:04:53Z

I also have some ui suggestions:

Add setting parameters to disable showing referenced and referencing relations.

What about having just a single action for "show relations", which applies to both? I'm worried about UI complexity. Honestly a decade later of using relations in qgis and I'm STILL confused by the referencing/referenced terminology 😝

Add a contextual menu item "Explore Feature" to be able to "re-center" the result of the identification tree on a nested feature, to limit the nesting depth.

How about "Identify Feature" instead? We don't use "explore" anywhere else, so I'm concerned this action won't be immediately understandable.

qgis-bot · 2024-06-24T20:05:56Z

@rouault
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

qgis-bot · 2024-06-24T20:05:57Z

@rouault

This pull request has been tagged for the changelog.

The description will be harvested so please provide a "nearly-ready" text for the final changelog
If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits

Funded by NAME
Funded by URL
Funded by NAME URL
Sponsored by NAME
Sponsored by URL
Sponsored by NAME URL

Thank you!

… from relations

…ntifyresultsdialog.cpp into testqgsidentify.cpp

…ng relations

rouault · 2024-06-24T21:26:54Z

What about having just a single action for "show relations", which applies to both? I

done

I'm STILL confused by the referencing/referenced terminology 😝

This both reassures and worries me as I'm also deeply confused :-)

How about "Identify Feature" instead? We don't use "explore" anywhere else, so I'm concerned this action won't be immediately understandable.

done

qgis-bot · 2024-06-25T04:19:50Z

@rouault
A documentation ticket has been opened at qgis/QGIS-Documentation#9148
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

github-actions bot added this to the 3.40.0 milestone Jun 24, 2024

nyalldawson reviewed Jun 24, 2024

View reviewed changes

nyalldawson added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jun 24, 2024

rouault added 4 commits June 24, 2024 23:06

[Identify tool] Make sure to destroy nested nodes for features coming…

56ad575

… from relations

tests/src/app/: merge testqgsmaptoolidentifyaction.cpp and testqgside…

fca80da

…ntifyresultsdialog.cpp into testqgsidentify.cpp

[Identify tool] Change to single setting for referenced and referenci…

077a4c1

…ng relations

[Identify tool] Rename 'Explore Feature' action to 'Identify Feature'

76a0c7f

nyalldawson approved these changes Jun 25, 2024

View reviewed changes

nyalldawson merged commit 02aa7af into qgis:master Jun 25, 2024
28 checks passed

qgis-bot mentioned this pull request Jun 25, 2024

[FEATURE] [Identify tool] Present referencing relations (in addition … (Request in QGIS) qgis/QGIS-Documentation#9148

Open

zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE] [Identify tool] Present referencing relations (in addition … #57863

[FEATURE] [Identify tool] Present referencing relations (in addition … #57863

rouault commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 24, 2024 •

edited

Loading

nyalldawson Jun 24, 2024

rouault Jun 24, 2024

nyalldawson Jun 24, 2024

rouault Jun 24, 2024

nyalldawson Jun 24, 2024

rouault Jun 24, 2024

nyalldawson commented Jun 24, 2024

qgis-bot commented Jun 24, 2024

qgis-bot commented Jun 24, 2024

rouault commented Jun 24, 2024

qgis-bot commented Jun 25, 2024

	<string>Show referenced relations</string>
	<string>Show Referenced Relations</string>

		@@ -0,0 +1,270 @@
		/***************************************************************************
		testqgsidentifyresultsdialog.cpp

[FEATURE] [Identify tool] Present referencing relations (in addition … #57863

[FEATURE] [Identify tool] Present referencing relations (in addition … #57863

Conversation

rouault commented Jun 24, 2024 • edited Loading

github-actions bot commented Jun 24, 2024 • edited Loading

🪟 Windows builds ready!

nyalldawson Jun 24, 2024

Choose a reason for hiding this comment

rouault Jun 24, 2024

Choose a reason for hiding this comment

nyalldawson Jun 24, 2024

Choose a reason for hiding this comment

rouault Jun 24, 2024

Choose a reason for hiding this comment

nyalldawson Jun 24, 2024

Choose a reason for hiding this comment

rouault Jun 24, 2024

Choose a reason for hiding this comment

nyalldawson commented Jun 24, 2024

qgis-bot commented Jun 24, 2024

qgis-bot commented Jun 24, 2024

rouault commented Jun 24, 2024

qgis-bot commented Jun 25, 2024

rouault commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 24, 2024 •

edited

Loading