Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve name and description of File Downloader Algorithm and fix failing SKIP OUTPUT (Request in QGIS) #9212

Closed
qgis-bot opened this issue Aug 27, 2024 · 1 comment · Fixed by #9337
Assignees
Labels
Processing Alg (Features of) An algorithm. Use the Help button in the application to find the page.

Comments

@qgis-bot
Copy link
Collaborator

Request for documentation

From pull request qgis/QGIS#58464
Author: @signedav
QGIS version: 3.40

Improve name and description of File Downloader Algorithm and fix failing SKIP OUTPUT

PR Description:

  • Changed name to "Download file (HTTP request)" because it's not given that a file download is performed by HTTP, and this is what this algorithm is about. Even more one easily can use it to perform HTTP requests without caring about the file.
  • Still the algorithm failed because of SKIP OUTPUT not passing a file path to the QgsFileDownloader why I set the parameter to mandatory instead
  • Additionally I added some tags

One could think about other improvements (but not part of this PR):

  • Allow not to download files and only perform requests
  • Put responses and / or status code (even on error) to the output

Commits tagged with [need-docs] or [FEATURE]

@signedav
Copy link
Contributor

signedav commented Aug 27, 2024

The new name is "Download File via HTTP(S)"

See qgis/QGIS#58464 (comment)

@DelazJ DelazJ added the Processing Alg (Features of) An algorithm. Use the Help button in the application to find the page. label Aug 27, 2024
@DelazJ DelazJ self-assigned this Oct 30, 2024
@DelazJ DelazJ closed this as completed in e30f8b7 Nov 5, 2024
qgis-bot pushed a commit that referenced this issue Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Processing Alg (Features of) An algorithm. Use the Help button in the application to find the page.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants