Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxies): define environment variable for proxy use for git clone #584

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

jmkerloch
Copy link
Collaborator

When a proxy is needed for git clone, dulwich and high level interface porcelain only use environment variable for proxy definition : HTTP_PROXY / HTTPS_PROXY

In this PR we are :

  • defining a wrapper for environment variable definition and backup
  • use wrapper for all function using porcelain for git command

@jmkerloch jmkerloch added the bug Something isn't working label Nov 29, 2024
@jmkerloch jmkerloch self-assigned this Nov 29, 2024
@jmkerloch jmkerloch requested a review from Guts November 29, 2024 07:41
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.35%. Comparing base (bf67a0f) to head (cfda597).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
qgis_deployment_toolbelt/utils/proxies.py 47.36% 6 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
- Coverage   70.43%   70.35%   -0.08%     
==========================================
  Files          47       47              
  Lines        3162     3188      +26     
  Branches      554      558       +4     
==========================================
+ Hits         2227     2243      +16     
- Misses        741      747       +6     
- Partials      194      198       +4     
Flag Coverage Δ
unittests 69.79% <61.53%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...loyment_toolbelt/profiles/profiles_handler_base.py 70.16% <100.00%> (+1.20%) ⬆️
qgis_deployment_toolbelt/utils/proxies.py 61.64% <47.36%> (-5.03%) ⬇️

Copy link
Collaborator

@Guts Guts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@Guts Guts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing and too generic docstring.

qgis_deployment_toolbelt/utils/proxies.py Show resolved Hide resolved
@jmkerloch jmkerloch requested a review from Guts November 29, 2024 11:37
jmkerloch and others added 3 commits November 29, 2024 12:42
- define wrapper for environment variable definition and backup
- use wrapper for all function using porcelain for git command
@jmkerloch jmkerloch force-pushed the fix/add_wrapper_for_porcelaine branch from 9d23214 to cfda597 Compare November 29, 2024 11:42
@jmkerloch jmkerloch enabled auto-merge November 29, 2024 11:42
@jmkerloch jmkerloch merged commit 3c2c7ca into main Nov 29, 2024
25 checks passed
@jmkerloch jmkerloch deleted the fix/add_wrapper_for_porcelaine branch November 29, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants