FIX BlockMeta repeat #20 ? #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some instances, multiple entries - in particular 'AB' seem to be present, onlky the the first one is valid. The supplementary instances are kept and added in the dict with a key ending by '_(1)', '_(2)', etc...
atravert
changed the title
atravert
changed the title
atravert
changed the title
FIX multiple entries with same name: In some instances, multiple entries - in particular 'AB' seem to be present, only the the first one is valid. Now the supplementary entries are kept and added in the dict with a key ending by '(1)', '(2)', etc...
|
Can confirm this. So far I have only found files with two spectral AB or Refl blocks, because of atmospheric compensation. That is how we deal in the R implementation. To join knowledge, would be great to know if this "additional_type" can be only 0 or 64, or actually have more representations (what you have solved with the dict stated above). https://github.com/spectral-cockpit/opusreader2/blob/e503ce3ae51155a77a1f94bae8eff9af1092fae4/R/read_header.R#L33 |
dzjkb
requested changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some instances, multiple entries with same name - in particular 'AB' seem to be present. In case of 'AB' only the the first one is valid. The supplementary instances are kept and added in the dict with a key ending by '(1)', '(2)', etc...
This should fix issues #20 and #15