Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc 103, candidate core and session #2282

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

rfc 103, candidate core and session #2282

wants to merge 20 commits into from

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • v2 candidate descriptor union
    • collator pubkey and signature
    • core and session
  • pvf backing check core and session (validate_candidate_exhaustive)
  • backing check core and session (kick_off_seconding)
  • fragment skipUmpSignals
  • statement distribution check attested candidate response
    • candidate hash
    • core and session
  • simplify NodeFeatures
  • remove ParachainHost_node_features unused session arg
  • remove unused FetchedCollation.collator_id
  • tested with zombienet 
    [relaychain.genesis.runtimeGenesis.patch.configuration.config.node_features]
data = [10] # ElasticScalingMVP=2 + CandidateReceiptV2=8

Possible Drawbacks

@turuslan
hide pubkey and signature
b9d28d3 
Signed-off-by: turuslan <[email protected]>
@turuslan
skip ump signals
917596c 
Signed-off-by: turuslan <[email protected]>
@turuslan
core and session index getter
23586c2 
Signed-off-by: turuslan <[email protected]>
@turuslan
enum
4b471f2 
Signed-off-by: turuslan <[email protected]>
@turuslan
comment
48e9040 
Signed-off-by: turuslan <[email protected]>
@turuslan
core selector
6e60a5d 
Signed-off-by: turuslan <[email protected]>
@turuslan
transpose
d80f105 
Signed-off-by: turuslan <[email protected]>
@turuslan
rename
26c95ee 
Signed-off-by: turuslan <[email protected]>
@turuslan
rename
818c854 
Signed-off-by: turuslan <[email protected]>
@turuslan
check core index
ce02de9 
Signed-off-by: turuslan <[email protected]>
@turuslan
descriptorVersionSanityCheck
7d045fb 
Signed-off-by: turuslan <[email protected]>
@turuslan
validate_candidate_exhaustive
3504924 
Signed-off-by: turuslan <[email protected]>
@turuslan
statement distribution
ce40ad8 
Signed-off-by: turuslan <[email protected]>
@turuslan
check session
ae8e3e9 
Signed-off-by: turuslan <[email protected]>
@turuslan
Merge remote-tracking branch 'origin/master' into rfc/103
a7083e3 
Signed-off-by: turuslan <[email protected]>

# Conflicts:
#	core/parachain/validator/statement_distribution/statement_distribution.cpp
@turuslan
fix
47fa418 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix build
a2b01e8 
Signed-off-by: turuslan <[email protected]>
kamilsa
kamilsa approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@kamilsa kamilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add links to corresponding Polkadot SDK structs/methods or RFC description references

core/parachain/candidate_descriptor_v2.hpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iceseer iceseer iceseer approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @kamilsa @iceseer