Delete snapshots API #1377
Merged
Delete snapshots API #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
approved these changes
Jan 20, 2023
generall
pushed a commit
that referenced
this pull request
Feb 6, 2023
* Delete snapshots API * remove unecessary plurals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API to delete snapshots tackling #1360
Two new REST endpoints:
DELETE /collections/{collection_name}/snapshots/{snapshot_name}DELETE /snapshots/{snapshot_name}And two new gRPC endpoints for feature parity.
A new openapi test for snapshots has been introduced to validate the behavior.
The doc and and clients integration is to be done.