Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(statefulset): add containerSecurityContext to init containers #178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(statefulset): add containerSecurityContext to init containers #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions charts/qdrant/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ spec:
volumeMounts:
- name: qdrant-storage
mountPath: /qdrant/storage
{{- with .Values.containerSecurityContext }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Johannes- , thanks for the contribution!

As mentioned here: #130 I think this would break by default since the init container needs to run as root, but using the default containerSecurityContext will make it run as user 1000.

Instead of re-using containerSecurityContext, could it be controlled by a new, separate setting called initContainerSecurityContext? May lead to duplication in peoples' values, but it allows people to assign different security contexts to each.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in #177 I removed the second init container, consolidating them into a single init container. That's probably what the merge conflict is.

securityContext:
{{- toYaml . | nindent 10 }}
{{- end }}
{{- if .Values.snapshotRestoration.enabled }}
- name: ensure-snapshots-dir-ownership
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
Expand All @@ -61,6 +65,10 @@ spec:
volumeMounts:
- name: qdrant-snapshots
mountPath: /qdrant/snapshots
{{- with .Values.containerSecurityContext }}
securityContext:
{{- toYaml . | nindent 10 }}
{{- end }}
{{- end }}
{{- end }}
{{- end }}
Expand Down