Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change upload points async #730

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Change upload points async #730

merged 4 commits into from
Aug 9, 2024

Conversation

hh-space-invader
Copy link
Contributor

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@netlify Netlify
Copy link

netlify bot commented Aug 9, 2024 •
edited
Loading

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit e4610b8
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/66b66b99a1dd6900084eed9d
😎 Deploy Preview https://deploy-preview-730--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein joein self-requested a review August 9, 2024 19:19
@joein joein merged commit f1da81d into dev Aug 9, 2024
13 of 14 checks passed
@joein joein mentioned this pull request Aug 9, 2024
Closed
joein added a commit that referenced this pull request Aug 12, 2024
@hh-space-invader @joein
Change upload points async (#730)
00bcc68 
* made upload_points sync

* updated base_client_generator

* fix: remove excess file

* refactoring: fix timeout type, remove redundant import

---------

Co-authored-by: George Panchuk <[email protected]>
@hh-space-invader hh-space-invader deleted the change-upload-points-async branch August 21, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joein joein joein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hh-space-invader @joein