Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing timeouts and regenerate grpc #721

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Add missing timeouts and regenerate grpc #721

merged 5 commits into from
Aug 9, 2024

Conversation

hh-space-invader
Copy link
Contributor

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@netlify Netlify
Copy link

netlify bot commented Aug 8, 2024 •
edited
Loading

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 0ed0973
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/66b657fa23df0c000880e44e
😎 Deploy Preview https://deploy-preview-721--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

joein
joein requested changes Aug 8, 2024
View reviewed changes
Copy link
Member

@joein joein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to poetry.lock should probably be removed from this PR

qdrant_client/async_qdrant_remote.py Show resolved Hide resolved
qdrant_client/async_qdrant_remote.py Show resolved Hide resolved
@hh-space-invader hh-space-invader force-pushed the add-missing-timeouts-and-regenerate-grpc branch from d8191fb to 26f40ec Compare August 9, 2024 05:32
@joein joein force-pushed the add-missing-timeouts-and-regenerate-grpc branch from 324808b to 622ac4f Compare August 9, 2024 15:07
@joein joein force-pushed the add-missing-timeouts-and-regenerate-grpc branch from 622ac4f to 4f5b30d Compare August 9, 2024 17:50
@joein joein merged commit 57f44d9 into dev Aug 9, 2024
14 checks passed
joein added a commit that referenced this pull request Aug 12, 2024
@hh-space-invader @joein
Add missing timeouts and regenerate grpc (#721)
42eb0a6 
* fixed missing grpc timeouts

* added timeouts in the corresponding rest calls of grpc

* regenerated grpc client

* new: add timeout to QdrantClient and AsyncQdrantClient

* fix: remove duplicated timeout arg

---------

Co-authored-by: George Panchuk <[email protected]>
@hh-space-invader hh-space-invader deleted the add-missing-timeouts-and-regenerate-grpc branch August 21, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joein joein joein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hh-space-invader @joein