Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop black #623

Merged
merged 6 commits into from
May 7, 2024
Merged

Drop black #623

merged 6 commits into from
May 7, 2024

Conversation

generall
Copy link
Member

@generall generall commented May 7, 2024

use ruff instead

Copy link

netlify bot commented May 7, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit ba1af3e
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/663a7721e5d06800089dc8ff
😎 Deploy Preview https://deploy-preview-623--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@generall generall requested a review from joein May 7, 2024 18:44
@generall generall merged commit 8556cc8 into dev May 7, 2024
13 of 14 checks passed
Comment on lines -25 to -28
hooks:
- id: isort
name: "Sort Imports"
args: ["--profile", "black", "--py", "310"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is isort missing in the new definition?

https://docs.astral.sh/ruff/formatter/#sorting-imports

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed as well

joein pushed a commit that referenced this pull request Jun 20, 2024
* replace black with ruff

* use line length

* remove isort

* regen async

* regen async

* fix ruff version [no-ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants