new: allow users to override providers #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NirantK
reviewed
Apr 28, 2024
Comment on lines
+61
to
+68
| available_providers = ort.get_available_providers() | ||
| for provider in onnx_providers: | ||
| # check providers available | ||
| provider_name = provider if isinstance(provider, str) else provider[0] | ||
| if provider_name not in available_providers: | ||
| raise ValueError( | ||
| f"Provider {provider_name} is not available. Available providers: {available_providers}" | ||
| ) |
There was a problem hiding this comment.
Thanks for adding the available_providers check!
|
I'm pushing a few changes to README with suggestions for user facing API. Would love to hear what you think @joein! |
Closed
joein
changed the title
generall
approved these changes
May 3, 2024
|
Hi @NirantK This is an awesome addition but I'm not sure if it is being realized. Have attached the collab link here - https://colab.research.google.com/drive/1I4Z547eE0utHmp2pxIgaLx0PXQhNFWdj?usp=sharing Thanks a lot! |
|
Hey @GautamR-Samagra, for some reason CUDAExecutionProvider has not been set in your notebook, we'll investigate it, thanks for sharing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #214, closes #52 and #97