doc: Add docs for Codespaces #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a subsection of 'Setup for a project' named 'Run inside GihHub Codespaces' in where is explained how to setup the devcontainer inside a GitHub Codespace. Fix #51
qdm12
reviewed
May 19, 2023
Fixed a typo inside 'Run inside GitHub Codespaces' section Co-authored-by: Quentin McGaw <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
qdm12
reviewed
May 28, 2023
Comment on lines
+76
to
+77
| # Docker socket to access Docker server | ||
| - /var/run/docker.sock:/var/run/docker.sock |
There was a problem hiding this comment.
Shouldn't this one be commented as well for codespaces?
Comment on lines
+79
to
+90
| - - ~/.ssh:/root/.ssh | ||
| + # - ~/.ssh:/root/.ssh | ||
| # For Windows without WSL, a copy will be made | ||
| # from /tmp/.ssh to ~/.ssh to fix permissions | ||
| - - ~/.ssh:/tmp/.ssh:ro | ||
| + # - ~/.ssh:/tmp/.ssh:ro | ||
| # Shell history persistence | ||
| - - ~/.zsh_history:/root/.zsh_history:z | ||
| + # - ~/.zsh_history:/root/.zsh_history:z | ||
| # Git config | ||
| - - ~/.gitconfig:/root/.gitconfig | ||
| + # - ~/.gitconfig:/root/.gitconfig |
There was a problem hiding this comment.
Actually thinking more about this, should we flip this around?
Comment them in .devcontainer/docker-compose.yml and not have this section in the readme?
That would make more sense I think.
I'll see what I can do with https://github.com/qdm12/devtainr as well so it can uncomment those fields when setting up a repo 😉 Created qdm12/devtainr#68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a subsection of 'Setup for a project' named 'Run inside GihHub Codespaces' in where is explained how to setup the devcontainer inside a GitHub Codespace.
Fix #51