-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colour and font themes part 2 #9283
Conversation
* @note Underscores in the element names mark positions of group separators, i.e. will be | ||
* replaced by '/' when saving to QSettings | ||
*/ | ||
enum class Element |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add here all QPalette
entries we will get the long anticipated dark mode on Windows. However, I'm not sure that dumping so many colours into the default themes is the best we can do. Namely, QPalette
contains 20 roles and 3 groups, that gives us 60 entries in total. We can omit their default values of course, but nevertheless they have to be listed in this enum. Maybe we can play a bit with the torrent states and group them into the same groups?
Here are the groups: Active, Disabled, Inactive.
We can do something like:
[Downloading,Active] -> ForcedDownloading
[Downloading,Inactive] -> Downloading
[Downloading,Disabled] -> StalledDownloading
But that is not perfect, of course. Any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey i know of another client: CuteTorrent, which is libtorrent-rasterbar & qt based that has switchable themes. It may help you I think. Its Themes repository |
Why does this keep being ignored? This is so ridiculous. |
Closed in favor of other implementation. |
After I updated and force-pushed my branch, GitHub does not allow me to reopen #7623, hence this new PR. Let's try it one more time....
The diff probably contains rebasing artefacts.