Ctrl+F search filter. Closes #5797.

[magao]

This pull request addresses issue #5797.

Changes Ctrl+F to focus the torrent filter text field and select all contents, as per the comments in #5797.

[magao]

Rebased on top of #6212 and uncrustified.

[zeule]

Do we really need the second commit ("Follow project coding style...") int this PR?

[magao]

mainwindow.h/cpp are only modified by this PR so I could extract that out from the other one.

Alternatively, I could just make sure the new code follows the coding style, and leave the rest of mainwindow.h/cpp as-is.

[zeule]

I like this little improvement, but it would be event better if you add also a shortcut to focus files filter in the content tab, i.e. when a torrent selected, the command switches to the "Content" tab and gives focus to the filter field there.

As a Plasma user, I would suggest Ctrl + I as the default shortcut.

[zeule]

Alternatively, I could just make sure the new code follows the coding style, and leave the rest of mainwindow.h/cpp as-is.

I would prefer it this way or reformat only actually touched files (mainwindow .h and .cpp) and rearrange commits to make the reformatting first.

[magao]

I like this little improvement, but it would be event better if you add also a shortcut to focus files filter in the content tab, i.e. when a torrent selected, the command switches to the "Content" tab and gives focus to the filter field there.

I think that should be a separate feature and pull request.

[magao]

I would prefer it this way or reformat only actually touched files (mainwindow .h and .cpp) and rearrange commits to make the reformatting first.

Since only this commit touches these files I'll pull uncrustifying mainwindow.h/cpp to its own commit. I had felt a single uncrustify commit was the best best approach, but if it holds up merging then it's obviously not.

[zeule]

What I'm objecting to is that the uncrustifying commit is positioned last and as such is kind of useless.

[magao]

Ah - that appears to be an artifact of how Github is presenting things. It's actually the first commit - all the other commits (and pull requests) have been rebased on top of 8501d44 (which is its own pull request #6212 so can be merged separately before all the others).

Might also partially be because I use Mercurial (via the hg-git extension) which preserves commit timestamps when rebasing (can't remember if Git does the same). So the other commits appear to be older than 8501d44.

So I won't do any changes to this PR for now.

[sledgehammer999]

Can you uncrustify only the files you touch in this PR. Commit it to this PR the new uncrustification.
I want to take in the uncrustification piece-by-piece.

[ngosang]

Tested in Linux and it works as expected.

[sledgehammer999]

Yeah, I am just waiting for @magao to renew his 2nd commit.

[magao]

@sledgehammer999 Rebased this PR on top of master. So it's got an uncrustify commit for mainwindow.cpp/h then a commit for the Ctrl+F changes.

[sledgehammer999]

Thank you.