Move old RSS items to separate config file. Closes #6167. #6175
Conversation
--HG-- branch : magao-dev
|
Rebased on top of #6212 and uncrustified. |
| } | ||
| else { | ||
| allOldItems = qBTRSS.value("old_items", QHash<QString, QVariant>()).toHash(); | ||
| } |
There was a problem hiding this comment.
move the migrating code under a function called "migrateRSS()" in the file `src/app/upgrade.h".
Then call it inside main() at the appropriate position.
Wrap all that code in:
#ifndef DISABLE_GUI
// do stuff
#endifAfter all this the code in this file will be much cleaner.
And in the future, we have to look at one place to remove old upgrading/migrating code.
|
Also doesn't old_items hold the RSS feeds actually? Then why not name the new file |
|
|
|
@sledgehammer999 Rebased PR on top of master and addressed review comments. |
| @@ -258,4 +258,23 @@ void macMigratePlists() | |||
| #endif // Q_OS_MAC | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I mean that 1 newline is fine.
| } | ||
| #endif | ||
|
|
||
|
|
|
@sledgehammer999 Fixed double-newlines, including existing doubled newlines before |
|
Thank you. |
This is one of a series of pull requests designed to improve the responsiveness of the UI. This pull request addresses #6167.
When editing RSS downloader rules, each edit results in persisting the rules to disk. Since the
old_itemsare in the same file, this also means persisting theold_itemsto disk each time a rule is edited. I have ~100 rules which use <1MB on disk, but theold_itemsuse ~70MB, so persisting them each edit affected responsiveness.This change moves the RSS
old_itemsfromqBittorrent-rss.confto a newqBittorrent-rss-items.conf. Existing entries are migrated on first run.