Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix error #5

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Feature/fix error #5

wants to merge 14 commits into from

Conversation

QBY-EstebanValverde
Copy link

@QBY-EstebanValverde QBY-EstebanValverde commented Mar 4, 2024 •
edited
Loading

Description

Added to main.tf template the subscription tags module and other improvement.

Change overview (tick true):

  • This introduces backward incompatible changes
  • This adds a new backward compatible Feature
  • This fixes a Bug

Version information:

  • Previous Version: 1.0.0

How Has This Been Tested?

  • Apply of all examples was successfull
  • Test B

Checklist:

  • I have run tests and documented them above
  • I have performed a self-review of my own code
  • I have updated the documentation
  • I have updated the CHANGELOG

ghost
ghost suggested changes Mar 4, 2024
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a change log!

AS the template doesn't need the stage anymore, can we remove it from the variables?

templates/locals.tftpl Outdated Show resolved Hide resolved
templates/main.tftpl Show resolved Hide resolved
templates/main.tftpl Outdated Show resolved Hide resolved
templates/main.tftpl Outdated Show resolved Hide resolved
templates/main.tftpl Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
templates/main.tftpl Show resolved Hide resolved
@QBY-EstebanValverde QBY-EstebanValverde requested a review from a user March 4, 2024 15:40
ghost
ghost suggested changes Mar 4, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I made mistakes in my suggestions :(

templates/virtual_machine.tftpl Outdated Show resolved Hide resolved
templates/vnet.tftpl Outdated Show resolved Hide resolved
templates/vnet.tftpl Outdated Show resolved Hide resolved
templates/locals.tftpl Outdated Show resolved Hide resolved
templates/azure-pipeline.tftpl Outdated Show resolved Hide resolved
@QBY-EstebanValverde QBY-EstebanValverde requested a review from a user March 4, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QBY-MarkusMaring QBY-MarkusMaring Awaiting requested review from QBY-MarkusMaring

@QBY-ChristianHartmann QBY-ChristianHartmann Awaiting requested review from QBY-ChristianHartmann

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@QBY-EstebanValverde