Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certification fqdns and entra connect not required #10

Merged
8 commits merged into from
May 30, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2024

Description

*.domain.com doesn't include domain.com. At least one deployment showed, that the root-sub domains of digicert are used.

During testing I noticed, that ipg_entra_connect_id variable was mandatory, although it shouldnt be, as it was a backward compatible feature and it borke the basic example.

Change overview (tick true):

  • This introduces backward incompatible changes
  • This adds a new backward compatible Feature
  • This fixes a Bug

Version information:

  • Previous Version: 2.1.0

How Has This Been Tested?

  • Apply of all examples was successfull

Checklist:

  • I have run tests and documented them above
  • I have performed a self-review of my own code
  • I have updated the documentation
  • I have updated the CHANGELOG

@ghost ghost requested a review from QBY-MarkusMaring May 30, 2024 09:44
@ghost ghost merged commit 86765df into main May 30, 2024
1 check passed
@ghost ghost deleted the fix/certification_fqdns branch May 30, 2024 09:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant