Bump github.com/onsi/gomega from 1.20.2 to 1.24.0 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.20.2 to 1.24.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.20.2...v1.24.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
Superseded by #20. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/onsi/gomega-1.24.0
branch
qbarrand
added a commit
that referenced
this pull request
Jun 2, 2023
Craft the modprobe command using properties from the CR. Rename the CRD group from oot to kmm. Rename some labels from oot to kmm.
qbarrand
added a commit
that referenced
this pull request
Jun 2, 2023
* Load firmware from the module loader (#17) It is common for kernel module to come with firmware(s). On immutable operating systems like CoreOS, the standard firmware path `/lib/firmware` is read-only. So, we need to let the kernel know where to lookup firmware file(s). This change adds the `FirmwarePath` attribute to the `ModprobeSpec` definition and modify the `MakeLoadCommand` and `MakeUnloadCommand` methods to leverage it. It also adds a `Volume` and a `VolumeMount` to expose the `/var/lib/firmware/<Module.Name>` host directory (created if it doesn't exist) inside the pod. The `/var/lib/firmware` is [the recommended path for firmwares in OpenShift with RHCOS nodes](https://access.redhat.com/documentation/fr-fr/openshift_container_platform/4.10/html-single/post-installation_configuration/index#rhcos-load-firmware-blobs_post-install-machine-configuration-tasks). Putting the firmware in a `Module.Name` subfolder avoids multiple Modules to override each others firmware. It also simplifies the removal of the firmware files. The `MakeLoadCommand` adds a step to copy the `FirmwarePath` to `/var/lib/firmware/<Module.Name>` to the `modprobe` command. The `MakeUnloadCommand` removes the firmware folder previously copied after unloading the module. The commands use `/usr/bin -c` to allow shell control like `&&`. Signed-off-by: Fabien Dupont <[email protected]> Signed-off-by: Fabien Dupont <[email protected]> * Use a strings.Builder in Make{Un,}LoadCommand (#46) This change replaces the many `append` statement with a `strings.Builder` stream to make the string creation more efficient. We also use this change to allow loading the firware even when `Modprobe.Args` is set, as it's not related to how modprobe itself is invoked. Signed-off-by: Fabien Dupont <[email protected]> Signed-off-by: Fabien Dupont <[email protected]> Signed-off-by: Fabien Dupont <[email protected]> Co-authored-by: Fabien Dupont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/onsi/gomega from 1.20.2 to 1.24.0.
Release notes
Sourced from github.com/onsi/gomega's releases.
... (truncated)
Changelog
Sourced from github.com/onsi/gomega's changelog.
... (truncated)
Commits
ed1156bv1.24.0756eaa0Update BeComparableTo documentation6015576finish documenting gcustom0cfc53bgodoc for gcustom6a2e51eFirst pass at gcustom: a convenience package for making custom matchers. Doc...bf817a4v1.23.07b8b801fix broken call to Eventuallyba35cc6Allow ctx to be passed in as a leading parameter for Eventually and Consistently818b78cAsyncAssertions emit the format.Object representation of the error when it i...d63d67eRename AsyncSignalError to PollingSignalErrorDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)