Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This closes #1921, fix set axis format doesn't work in combo chart #1924

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

user1121114685
Copy link
Contributor

PR Details

This closes #1921, fix set axis format doesn't work in combo chart

Description

Better compatibility, and fix set axis format doesn't work in combo chart

Related Issue

Motivation and Context

Better compatibility, and fix set axis format doesn't work in combo chart

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (c349313) to head (8157e4d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
- Coverage   99.30%   99.30%   -0.01%     
==========================================
  Files          32       32              
  Lines       24989    24960      -29     
==========================================
- Hits        24815    24786      -29     
  Misses         93       93              
  Partials       81       81              
Flag Coverage Δ
unittests 99.30% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 1a99dd4 into qax-os:master Jun 17, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
No open projects
Status: Bugfix
Development

Successfully merging this pull request may close these issues.

Combo Column + Line chart with secondary invisible axis produces unexpected results.
2 participants