-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DelComment #1317
feat: DelComment #1317
Conversation
new DelComment function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I've left some comments.
Codecov Report
@@ Coverage Diff @@
## master #1317 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 31 31
Lines 23482 23511 +29
=======================================
+ Hits 23124 23153 +29
Misses 239 239
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes based on your branch.
happy weekend! Thank you for your help! @xuri |
…omment (qax-os#1317) - Update unit tests for the delete comment - Add 3 errors function for error messages
…omment (qax-os#1317) - Update unit tests for the delete comment - Add 3 errors function for error messages
…omment (qax-os#1317) - Update unit tests for the delete comment - Add 3 errors function for error messages
…omment (qax-os#1317) - Update unit tests for the delete comment - Add 3 errors function for error messages
new DelComment function
PR Details
Description
增加删除批注功能函数 DelComment [#849 ]
Motivation and Context
最近项目有用到这个库,挺棒的一个库!刚好在社群又看到有这么个需求,于是尝试贡献下自己的代码。
How Has This Been Tested
添加了一个单元测试函数
Types of changes
Checklist