Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pydantic clippy lints on project #901

Merged
merged 8 commits into from
Jan 28, 2023
Merged

Run pydantic clippy lints on project #901

merged 8 commits into from
Jan 28, 2023

Conversation

qarmin
Copy link
Owner

@qarmin qarmin commented Jan 26, 2023

Quite complicated command

cargo +1.65 clippy -- -Wclippy::pedantic -Aclippy::case_sensitive_file_extension_comparisons -Aclippy::match_wildcard_for_single_variants -Aclippy::cast_possible_wrap -Aclippy::trivially_copy_pass_by_ref -Aclippy::if_not_else -Aclippy::missing_errors_doc -Aclippy::cast_sign_loss -Aclippy::cast_possible_truncation -Aclippy::cast_lossless -Aclippy::default_trait_access -Aclippy::wildcard_imports -Aclippy::too_many_lines -Aclippy::unused_self -Aclippy::cast_precision_loss -Aclippy::missing_panics_doc -Aclippy::struct_excessive_bools -Aclippy::module_name_repetitions -Aclippy::implicit_hasher -Aclippy::inconsistent_struct_constructor

Looks that may very very little this change performance, since now a lot of things is passed by reference instead copying

@qarmin
Copy link
Owner Author

qarmin commented Jan 28, 2023

Looks that one of requirements bumped minimal version os to Ubuntu 20.04(GLIBC 2.28 required)

@qarmin qarmin merged commit 8ea9b4b into master Jan 28, 2023
@qarmin qarmin deleted the pydantic branch January 28, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant