Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Winows theme in CI builds #265

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Fix Winows theme in CI builds #265

merged 1 commit into from
Feb 20, 2021

Conversation

krzysdz
Copy link
Contributor

@krzysdz krzysdz commented Feb 17, 2021

The admin-gtk3-dark-osx theme contains relative symlinks, which after copying only this theme are no longer valid.
The -L (--dereference) option makes cp always follow symbolic links, so that all of them are replaced with files they pointed to.

The zip command ignored these invalid symlinks (zip warning: name not matched in logs) and the CI builds didn't contain the assets/, windows-assets/ directories and assets.svg, assets.txt files.

This fixes rhodesn/AdMin#11.

The admin-gtk3-dark-osx theme contains relative symlinks, which after copying only this theme are no longer valid.
The -L (--dereference) option makes cp always follow symbolic links, so that all of them are replaced with files they pointed to.
@krzysdz krzysdz changed the title Fix Winows theme in CI Fix Winows theme in CI builds Feb 17, 2021
@krzysdz
Copy link
Contributor Author

krzysdz commented Feb 17, 2021

Before (3ad1dfa, artifacts from this run) and after (988ce92, artifacts from this run) comparison.

Before and after - checkboxes and window icons are now fixed

@qarmin qarmin added the bug Something isn't working label Feb 18, 2021
@qarmin qarmin merged commit 2e7c5c2 into qarmin:master Feb 20, 2021
@qarmin
Copy link
Owner

qarmin commented Feb 20, 2021

Thanks!

LJason77 pushed a commit to LJason77/czkawka that referenced this pull request Feb 20, 2021
The admin-gtk3-dark-osx theme contains relative symlinks, which after copying only this theme are no longer valid.
The -L (--dereference) option makes cp always follow symbolic links, so that all of them are replaced with files they pointed to.
@krzysdz krzysdz deleted the patch-1 branch February 20, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange square checkboxes on WIndows
2 participants