Ignore duplicates if those are hard links #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blob79
force-pushed
the
hard_links
branch
2 times, most recently
from
4ffe4ae to
2669688
Compare
qarmin
approved these changes
Feb 3, 2021
qarmin
requested changes
Feb 3, 2021
czkawka_core/src/duplicate.rs
Outdated
Comment on lines
912
to
915
| let dups = self.filter_hard_links(vec_file_entry); | ||
| if dups.len() > 1 { | ||
| self.files_with_identical_hashes.entry(size).or_insert_with(Vec::new); | ||
| self.files_with_identical_hashes.get_mut(&size).unwrap().push(vec_file_entry); | ||
| self.files_with_identical_hashes.get_mut(&size).unwrap().push(dups); |
There was a problem hiding this comment.
This should be moved into check_file_size function, because for now this only works for full file hashing and checking files before hashing will allow to drop some records before doing such resource heavy operation.
|
Thanks for this improvement, I guess it would be also nice to choose whether it will be ignored or not. |
blob79
force-pushed
the
hard_links
branch
3 times, most recently
from
f7efde7 to
ba705df
Compare
This is a proof of concept.
```
$ echo a > hardlinks/a
$ cp hardlinks/{a,b}
$ ln hardlinks/{a,c}
$ cargo run --bin czkawka_cli dup -m 1 --directories $(pwd)/hardlinks -f /dev/stderr > /dev/null
-------------------------------------------------Files with same hashes-------------------------------------------------
Found 1 duplicated files which in 1 groups which takes 2 B.
---- Size 2 B (2) - 2 files
/home/thomas/Development/czkawka/hardlinks/a
/home/thomas/Development/czkawka/hardlinks/b
```
Open:
- Windows support
- Probably this should be a cli option
|
Thanks! |
LJason77
pushed a commit
to LJason77/czkawka
that referenced
this pull request
Feb 20, 2021
This is a proof of concept.
```
$ echo a > hardlinks/a
$ cp hardlinks/{a,b}
$ ln hardlinks/{a,c}
$ cargo run --bin czkawka_cli dup -m 1 --directories $(pwd)/hardlinks -f /dev/stderr > /dev/null
-------------------------------------------------Files with same hashes-------------------------------------------------
Found 1 duplicated files which in 1 groups which takes 2 B.
---- Size 2 B (2) - 2 files
/home/thomas/Development/czkawka/hardlinks/a
/home/thomas/Development/czkawka/hardlinks/b
```
Open:
- Windows support
- Probably this should be a cli option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept.
Open: