feat: add hostname to backup filename for a unique filename

qaldak · Nov 20, 2023 · e9201bf · e9201bf
1 parent 50c589a
commit e9201bf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/container/backup.py b/src/container/backup.py
@@ -2,6 +2,8 @@
 
 from python_on_whales import docker, DockerException
 
+from util.accessor import LocalHost
+
 logger = logging.getLogger(__name__)
 
 
@@ -13,7 +15,7 @@ def create_tar_cmd(container) -> list[str]:
     :return: tar command to execute
     """
 
-    tar_cmd = ["tar", "-czf", f"/backup/{container.name}_volume_backup.tar.gz"]
+    tar_cmd = ["tar", "-czf", f"/backup/{LocalHost.get_hostname()}_{container.name}_volume_backup.tar.gz"]
 
     for volume in container.docker_volumes:
         tar_cmd.append(f"{volume}")

diff --git a/tests/container/test_backup.py b/tests/container/test_backup.py
@@ -53,7 +53,9 @@ def test_run_backup_successful(self, tmp):
             self.assertEqual(["INFO:container.backup:Volume backup for container 'foo_bar' successful"], log.output)
 
 
-def test_create_tar_cmd():
+@patch("src.container.backup.LocalHost.get_hostname", return_value="groot")
+def test_create_tar_cmd(host):
     container = MockContainer()
     tar_cmd = create_tar_cmd(container)
-    assert ["tar", "-czf", f"/backup/foo_bar_volume_backup.tar.gz", "/foo/data", "/foo/config", "/bar/log"] == tar_cmd
+    assert ["tar", "-czf", f"/backup/groot_foo_bar_volume_backup.tar.gz", "/foo/data", "/foo/config",
+            "/bar/log"] == tar_cmd