Changes to code style #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cserb
commented
Feb 1, 2020
cserb
commented
- followed ameba linting https://crystal-ameba.github.io/
- followed crystal coding style convention https://crystal-lang.org/reference/conventions/coding_style.html
- removed unreachable code
|
|
q9f
approved these changes
Feb 10, 2020
| @@ -40,7 +40,7 @@ | |||
| <div class="types-list"> | |||
| <ul> | |||
|
|
|||
| <li class="parent open" data-id="github.com/q9f/secp256k1.cr/Secp256k1" data-name="secp256k1"> | |||
There was a problem hiding this comment.
can you restore the open class here?
There was a problem hiding this comment.
I don't know how to do that, since this is generated by crystal doc
| @@ -451,7 +446,7 @@ module Secp256k1::Bitcoin | |||
| pk_checksum = hashed_twice[0, 8] | |||
| valid = valid && wif_checksum === pk_checksum | |||
| end | |||
| return valid | |||
| valid | |||
There was a problem hiding this comment.
i personally prefer having return statements to improve readability but I'm not very opinionated about it, so LGTM
There was a problem hiding this comment.
I actually concur, but the crystal/ruby community decided to use return only for early break outs
* followed ameba linting https://crystal-ameba.github.io/ * followed crystal coding style convention https://crystal-lang.org/reference/conventions/coding_style.html * removed unreachable code * version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.