Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/client: fix account requirement for client.call() #85

Merged
merged 3 commits into from
May 11, 2022
Merged

Conversation

q9f
Copy link
Owner

@q9f q9f commented May 10, 2022

if you use a client that does not have a coinbase (infura, dappnode, etc), you cannot call contracts.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #85 (6b8c5a2) into main (28b7fe0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   99.73%   99.73%   -0.01%     
==========================================
  Files          67       67              
  Lines        3802     3801       -1     
==========================================
- Hits         3792     3791       -1     
  Misses         10       10              
Impacted Files Coverage Δ
lib/eth/client.rb 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

lib/eth/client.rb Outdated Show resolved Hide resolved
@q9f q9f merged commit 033d2fc into main May 11, 2022
@q9f q9f deleted the q9f/client/call branch May 11, 2022 14:42
@q9f q9f added the bug Something isn't working label May 13, 2022
mculp pushed a commit to mculp/eth.rb that referenced this pull request Aug 1, 2022
* eth/client: fix account requirement for client.call()

* eth/client: allow passing key to call()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants