Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/signature: fix allowing ledger v values of 0 #155

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

q9f
Copy link
Owner

@q9f q9f commented Oct 31, 2022

fix #138

@q9f q9f added the bug Something isn't working label Oct 31, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #155 (7b9b71d) into main (003dbe8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          68       68           
  Lines        3968     3983   +15     
=======================================
+ Hits         3958     3973   +15     
  Misses         10       10           
Impacted Files Coverage Δ
lib/eth/chain.rb 100.00% <100.00%> (ø)
lib/eth/signature.rb 100.00% <100.00%> (ø)
spec/eth/chain_spec.rb 100.00% <100.00%> (ø)
spec/eth/signature_spec.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@q9f q9f merged commit 1985320 into main Oct 31, 2022
@q9f q9f deleted the q9f/fix/ledger/v branch October 31, 2022 12:46
a-moreira pushed a commit to a-moreira/eth.rb that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth/signature: Unable to recover/verify some signatures from Ledger wallets
2 participants