Fixed compile error (issue foliojs#45) - upgraded nan to >= 2.14.0 an…

…d fixed a call in FontDescriptor.h
q-lukasz · Jan 28, 2020 · 523d3b3 · 523d3b3
1 parent 33b102e
commit 523d3b3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -5,7 +5,7 @@
   "main": "build/Release/fontmanager",
   "types": "index.d.ts",
   "dependencies": {
-    "nan": ">=2.10.0"
+    "nan": ">=2.14.0"
   },
   "devDependencies": {
     "mocha": "*"

diff --git a/src/FontDescriptor.h b/src/FontDescriptor.h
@@ -173,7 +173,7 @@ struct FontDescriptor {
     MaybeLocal<Value> value = Nan::Get(obj, Nan::New<String>(name).ToLocalChecked());
 
     if (!value.IsEmpty() && value.ToLocalChecked()->IsBoolean()) {
-      return value.ToLocalChecked()->BooleanValue(Nan::GetCurrentContext()).FromJust();
+      return value.ToLocalChecked()->BooleanValue((Nan::GetCurrentContext())->GetIsolate());
     }
 
     return false;