Fixes argument usage in AST transform #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2020 07:26
|
CI isn't kicking off, but a run did pass: https://travis-ci.org/pzuraq/ember-simple-set-helper/builds/656307399 |
pzuraq
changed the title
|
I guess it fixes #6? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reproduction of the bug outlined in emberjs/ember.js#18779
You can run the failing test by running:
yarn test -s -f='it works without a value on an object'. I have also reproduced the issue on dummy app homepage.Apologies but just to make sure I was accurately reproducing the issue in my app I upgraded the addon using
ember-cli-updateand fixed up some linting.You can find the actual reproduction in 80da59e